Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table configuration class #196

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Add table configuration class #196

merged 2 commits into from
Aug 28, 2023

Conversation

m-rudyk
Copy link
Collaborator

@m-rudyk m-rudyk commented Aug 16, 2023 •
edited
Loading

Description

Add an option to configure database tables for the open-source LPVS.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.

Test Configuration:

  • Java: v11
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@m-rudyk m-rudyk changed the title feat: add table configuration class Add table configuration class Aug 17, 2023
@tdrozdovsky tdrozdovsky self-requested a review August 17, 2023 06:22
@tdrozdovsky tdrozdovsky marked this pull request as ready for review August 17, 2023 06:23
tdrozdovsky
tdrozdovsky approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@tdrozdovsky tdrozdovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

o-kopysov
o-kopysov approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add app.table.* into application.properties?

@m-rudyk
Copy link
Collaborator Author

m-rudyk commented Aug 17, 2023

Do we need to add app.table.* into application.properties?

Yes, sure. We will do that in configuration PR (there are 2 more steps required).

@m-rudyk m-rudyk merged commit c2f49ae into Samsung:main Aug 28, 2023
@m-rudyk m-rudyk deleted the m.rudyk/sync_with_internal_add_table_configuration branch February 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiokim tiokim tiokim left review comments

@tdrozdovsky tdrozdovsky tdrozdovsky approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-rudyk @tiokim @o-kopysov @tdrozdovsky